Remove -vv by default for pytest#595
Open
llucax wants to merge 5 commits into
Open
Conversation
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
For projects with many tests, the `-vv` default produces a wall of output that makes it hard to see the results from other, previous, sessions. Drop the default from the generated `pyproject.toml` so each project can opt in if it wants. Regenerated the golden fixtures for all repository types and both license variants. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Mirror the template change that drops `addopts = "-vv"` from `[tool.pytest.ini_options]` so existing repositories pick it up too. The step removes the `addopts = "-vv"` line when it matches the template default verbatim, leaves customized `addopts` values alone (with a manual step asking the maintainer to drop `-vv` if they want), and is a no-op when the line is already gone or the `[tool.pytest.ini_options]` section is missing. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Apply the matching migration step to this repository so its own `pyproject.toml` no longer ships `addopts = "-vv"` under `[tool.pytest.ini_options]`. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
florian-wagner-frequenz
and removed request for
a team
github-actions
Bot
added
the
part:template
| return | ||
|
|
||
| pytest_section = pytest_section_match.group(0) | ||
| addopts_match = re.search(r"^addopts\s*=.*$", pytest_section, flags=re.MULTILINE) |
Contributor
There was a problem hiding this comment.
This needs to import re previously removed it in the reset commit
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
Contributor
There was a problem hiding this comment.
The checks fail because of a missing import, LGTM otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594.